Fix: Install Apple Silicon shows Universal as Installing#787
Open
William-Laverty wants to merge 1 commit intoXcodesOrg:mainfrom
Open
Fix: Install Apple Silicon shows Universal as Installing#787William-Laverty wants to merge 1 commit intoXcodesOrg:mainfrom
William-Laverty wants to merge 1 commit intoXcodesOrg:mainfrom
Conversation
When clicking 'Install Apple Silicon', the UI incorrectly shows the Universal version as 'Installing' instead of the Apple Silicon version. Root cause: setInstallationStep used version.isEquivalent() which doesn't consider architectures. When both Universal and Apple Silicon exist with the same version, the first one found (Universal) was marked as installing. Fix: Change setInstallationStep to accept XcodeID instead of Version, enabling exact matching including architectures. Fixes XcodesOrg#776, XcodesOrg#777, XcodesOrg#782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When clicking 'Install Apple Silicon', the UI incorrectly shows the Universal version as 'Installing' instead of the Apple Silicon version.
Root Cause
setInstallationStepusedversion.isEquivalent()which doesn't consider architectures. When both Universal and Apple Silicon versions exist with the same Xcode version, the first one found (Universal) was marked as installing.Fix
Changed
setInstallationStepto acceptXcodeIDinstead ofVersion, enabling exact matching including architectures:Testing
Fixes #776, #777, #782